tools/libxl: Don't prepare or save xc_config when soft resetting a domain
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 9 Mar 2018 13:03:26 +0000 (13:03 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 5 Apr 2018 09:43:13 +0000 (10:43 +0100)
commit2649612686f968a52ce53d173f5c2a3088ad17dd
tree81be59d4abf5bca457a972656a40654a8146f2a8
parent74fd984ae699727ae98f4fc36450ff76c8fc7ff3
tools/libxl: Don't prepare or save xc_config when soft resetting a domain

xc_config is only used by xc_domain_create(), but by calling
libxl__arch_domain_{prepare,save}_config() we clobber the real settings with
the default settings.

Move all data and calls relating to xc_domain_create() into the path which
calls it.

As far as I can tell, soft_reset has always been broken for ARM domains using
LIBXL_GIC_VERSION_DEFAULT, which elicits a hard error out of
libxl__arch_domain_save_config(), and only works on x86 because this function
is a no-op.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
tools/libxl/libxl_create.c